fix: clean up

algolia · Jul 20, 2021 · 434f276 · 434f276
1 parent 1d50f0c
commit 434f276
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/packages/autocomplete-core/src/__tests__/getSources.test.ts b/packages/autocomplete-core/src/__tests__/getSources.test.ts
@@ -119,10 +119,10 @@ describe('getSources', () => {
           createSource({
             sourceId: 'source1',
             getItems: () => {
-              const obj = { a: 'b', self: null };
-              obj.self = obj;
+              const circular = { a: 'b', self: null };
+              circular.self = circular;
 
-              return [obj];
+              return [circular];
             },
           }),
         ];

diff --git a/packages/autocomplete-core/src/utils/__tests__/getNormalizedSources.test.ts b/packages/autocomplete-core/src/utils/__tests__/getNormalizedSources.test.ts
@@ -67,10 +67,10 @@ describe('getNormalizedSources', () => {
   });
 
   test('with wrong `getSources` function return type containing circular references triggers invariant', async () => {
-    const cyclic = { self: null };
-    cyclic.self = cyclic;
+    const circular = { self: null };
+    circular.self = circular;
 
-    const getSources = () => cyclic;
+    const getSources = () => circular;
     const params = {
       query: '',
       state: createState({}),

diff --git a/packages/autocomplete-shared/src/__tests__/decycle.test.ts b/packages/autocomplete-shared/src/__tests__/decycle.test.ts
@@ -3,13 +3,13 @@ import { decycle } from '../decycle';
 describe('decycle', () => {
   if (__DEV__) {
     test('leaves objects with no circular references intact', () => {
-      const obj = { a: 1 };
-      const subject = {
+      const ref = { a: 1 };
+      const obj = {
         a: 'b',
-        c: { d: [obj, () => {}, null, false, undefined] },
+        c: { d: [ref, () => {}, null, false, undefined] },
       };
 
-      expect(decycle(subject)).toEqual({
+      expect(decycle(obj)).toEqual({
         a: 'b',
         c: { d: [{ a: 1 }, expect.any(Function), null, false, undefined] },
       });