fix(dataset): avoid usage of callNow for debounce

algolia · May 24, 2018 · 1a0ce74 · 1a0ce74
1 parent 50240ee
commit 1a0ce74
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 4 deletions.
diff --git a/src/autocomplete/dataset.js b/src/autocomplete/dataset.js
@@ -214,12 +214,8 @@ _.mixin(Dataset.prototype, EventEmitter, {
           that.debounceTimeout = null;
           execSource();
         };
-        var callNow = !this.debounceTimeout;
         clearTimeout(this.debounceTimeout);
         this.debounceTimeout = setTimeout(later, this.debounce);
-        if (callNow) {
-          execSource();
-        }
       } else {
         execSource();
       }

diff --git a/test/unit/dataset_spec.js b/test/unit/dataset_spec.js
@@ -342,6 +342,28 @@ describe('Dataset', function() {
       this.dataset.update('woah 2');
       expect(this.source.calls.count()).toBe(2);
     });
+
+    it('should wait before calling the source if debounce is provided', function(done) {
+      var that = this;
+
+      this.dataset = new Dataset({
+        source: this.source,
+        debounce: 250
+      });
+
+      this.source.and.callFake(fakeGetWithSyncResultsAndExtraParams);
+
+      this.dataset.update('woah');
+      expect(this.source.calls.count()).toBe(0);
+
+      this.dataset.update('woah 2');
+      expect(this.source.calls.count()).toBe(0);
+
+      setTimeout(function() {
+        expect(that.source.calls.count()).toBe(1);
+        done();
+      }, 500);
+    });
   });
 
   describe('#cacheSuggestions', function() {