fix(specs): subscription specific action #4363
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
shortcuts
reviewed
Feb 18, 2025
| @@ -24,6 +24,8 @@ Task: | |||
| $ref: '#/failureThreshold' | |||
| action: | |||
| $ref: '#/ActionType' | |||
| subscriptionAction: | |||
| $ref: '#/ActionType' | |||
There was a problem hiding this comment.
I don't see any reason to prevent users from using all the action types from the API
There was a problem hiding this comment.
idk that's what you've defined here https://github.com/algolia/data-ingestion/pull/4209/files#diff-fa97414956590beac45ae2eeb9901f8bd0194734da4fa7b2f816368075cfa88cR53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: relates to DI-3278
Changes included:
Warning
Wait for the definitive name before merging