Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): add missing message attribute to GetObjectsResponse [skip-bc] #4029

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

kombucha
Copy link
Contributor

@kombucha kombucha commented Oct 24, 2024

🧭 What and Why

🎟 JIRA Ticket: just trying to make a small contribution :)

Changes included:

Add missing message attribute to GetObjectsResponse

Screenshot 2024-10-24 at 18 18 25

@kombucha kombucha self-assigned this Oct 24, 2024
@kombucha kombucha requested a review from a team as a code owner October 24, 2024 16:18
@kombucha kombucha requested review from Fluf22 and shortcuts October 24, 2024 16:18
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 24, 2024

✔️ Code generated!

Name Link
🪓 Triggered by b592e3edf17cd2ba1e5db53860423cde72276fa8
🍃 Generated commit 17da8d0f8bc65adfc17f7d4257b9f40d72831ab1
🌲 Generated branch generated/feat/add-message-attribute-get-objects-response
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1680
go 1601
php 1523
csharp 1316
java 1120
python 1081
ruby 888
swift 770

Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks 🙏🏻

@kombucha kombucha changed the title feat(specs): add missing message attribute to GetObjectsResponse feat(specs): add missing message attribute to GetObjectsResponse [skip-bc] Oct 24, 2024
@kombucha kombucha force-pushed the feat/add-message-attribute-get-objects-response branch from bba9fea to a22dd04 Compare October 24, 2024 17:20
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@shortcuts shortcuts merged commit 312d337 into main Oct 24, 2024
28 checks passed
@shortcuts shortcuts deleted the feat/add-message-attribute-get-objects-response branch October 24, 2024 18:13
algolia-bot added a commit that referenced this pull request Oct 24, 2024
…p-bc] (#4029) (generated) [skip ci]

Co-authored-by: Vincent Lemeunier <vincentlemeunier+git@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Oct 24, 2024
…p-bc] (generated)

algolia/api-clients-automation#4029

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Vincent Lemeunier <vincentlemeunier+git@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Oct 24, 2024
…p-bc] (generated)

algolia/api-clients-automation#4029

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Vincent Lemeunier <vincentlemeunier+git@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Oct 24, 2024
…p-bc] (generated)

algolia/api-clients-automation#4029

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Vincent Lemeunier <vincentlemeunier+git@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Oct 24, 2024
…p-bc] (generated)

algolia/api-clients-automation#4029

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Vincent Lemeunier <vincentlemeunier+git@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Oct 24, 2024
…p-bc] (generated)

algolia/api-clients-automation#4029

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Vincent Lemeunier <vincentlemeunier+git@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Oct 24, 2024
…p-bc] (generated)

algolia/api-clients-automation#4029

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Vincent Lemeunier <vincentlemeunier+git@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Oct 24, 2024
…p-bc] (generated)

algolia/api-clients-automation#4029

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Vincent Lemeunier <vincentlemeunier+git@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Oct 24, 2024
…p-bc] (generated)

algolia/api-clients-automation#4029

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Vincent Lemeunier <vincentlemeunier+git@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Oct 24, 2024
…p-bc] (generated)

algolia/api-clients-automation#4029

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Vincent Lemeunier <vincentlemeunier+git@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Oct 24, 2024
…p-bc] (generated)

algolia/api-clients-automation#4029

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Vincent Lemeunier <vincentlemeunier+git@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Oct 24, 2024
…p-bc] (generated)

algolia/api-clients-automation#4029

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Vincent Lemeunier <vincentlemeunier+git@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants