Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): rename ingestion list methods #3411

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

There's inconsistencies between our specs principle, our return types and our operation names.

For the better, and before GA, we should align on those names.

@shortcuts shortcuts self-assigned this Jul 24, 2024
@shortcuts shortcuts requested a review from a team as a code owner July 24, 2024 09:20
@shortcuts shortcuts requested review from morganleroi and millotp and removed request for a team July 24, 2024 09:20
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 24, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 27fc9add498b6dce25081db6ba4c459cac93f507
🍃 Generated commit d320df46315843e2f157a55f66404aa80e3433db
🌲 Generated branch generated/fix/ingestion-method-naming
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Rate
javascript 1386
php 1331
csharp 1104
java 892
ruby 888
python 750
swift 738
kotlin 486
go 457

Copy link
Contributor

@morganleroi morganleroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes !

@shortcuts shortcuts merged commit 3f317fd into feat/ingestion-tasks-v2 Jul 24, 2024
21 checks passed
@shortcuts shortcuts deleted the fix/ingestion-method-naming branch July 24, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants