Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(go): add ChunkedBatch and ReplaceAllObjects #2935

Merged
merged 2 commits into from
Mar 27, 2024
Merged

feat(go): add ChunkedBatch and ReplaceAllObjects #2935

merged 2 commits into from
Mar 27, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-1843

Changes included:

  • Add ReplaceAllObjects helper
  • Add ChunkedBatch helper

I'll add helper tests asap but the mock part discouraged me so brb

@shortcuts shortcuts self-assigned this Mar 27, 2024
@shortcuts shortcuts requested a review from a team as a code owner March 27, 2024 16:10
@shortcuts shortcuts requested review from morganleroi and Fluf22 March 27, 2024 16:10
@algolia-bot
Copy link
Collaborator

algolia-bot commented Mar 27, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Fluf22
Fluf22 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2024 •
edited
Loading

🚀 Deployed on https://6604809f5c4d84539c195459--api-clients-automation.netlify.app

@github-actions github-actions bot temporarily deployed to pull request March 27, 2024 16:20 Inactive
@shortcuts shortcuts enabled auto-merge (squash) March 27, 2024 20:15
@github-actions github-actions bot temporarily deployed to pull request March 27, 2024 20:25 Inactive
@shortcuts shortcuts merged commit 2a673e2 into main Mar 27, 2024
13 checks passed
@shortcuts shortcuts deleted the feat/go-chunkedbatch-replaceallobjects branch March 27, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fluf22 Fluf22 Fluf22 approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shortcuts @algolia-bot @Fluf22