Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(generators): add uniqueHost property #2561

Merged
merged 6 commits into from
Jan 18, 2024
Merged

fix(generators): add uniqueHost property #2561

merged 6 commits into from
Jan 18, 2024

Conversation

morganleroi
Copy link
Contributor

@morganleroi morganleroi commented Jan 17, 2024 •
edited
Loading

🧭 What and Why

Monitoring API configuration is not correctly generated. We use the {appId}-dsn.algolia.net format but this host does not exist for the Monitoring API.

the spec is correct and only define the unique available host.

We need to introduce a new property uniqueHost to avoid fallback to {appId}-dsn.algolia.net format in our configuration files.

C# example is provided.

🎟 JIRA Ticket:

@netlify Netlify
Copy link

netlify bot commented Jan 17, 2024 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 67749fc
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65a8f02d63a24300086b8746
😎 Deploy Preview https://deploy-preview-2561--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 17, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@morganleroi morganleroi changed the title fix: add unique server property fix: add uniqueHost property Jan 17, 2024
@morganleroi morganleroi marked this pull request as ready for review January 17, 2024 15:17
@morganleroi morganleroi requested a review from a team as a code owner January 17, 2024 15:17
@morganleroi morganleroi requested review from Fluf22 and millotp January 17, 2024 15:18
@morganleroi morganleroi changed the title fix: add uniqueHost property fix(generators): add uniqueHost property Jan 17, 2024
Fluf22
Fluf22 previously approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix!
I knew something was wrong with my Monitoring client 😄

millotp
millotp previously approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ! maybe it could be simplified with more variables, like isSingleHost, isRegionalHosts, isAppIDHosts... I'm not sure

@morganleroi morganleroi dismissed stale reviews from millotp and Fluf22 via 28344fc January 17, 2024 18:23
@morganleroi morganleroi requested review from millotp and Fluf22 January 17, 2024 18:33
@shortcuts
Copy link
Member

that's nice good catch! do we contribute to your pr directly?

@millotp millotp mentioned this pull request Jan 17, 2024
Merged
Fluf22
Fluf22 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say we should each do our PRs separately

@shortcuts shortcuts mentioned this pull request Jan 18, 2024
Merged
@shortcuts shortcuts enabled auto-merge (squash) January 18, 2024 09:26
@millotp
Copy link
Collaborator

millotp commented Jan 18, 2024

The CTS should be aware of that change too, the client test for monitoring is not correct right now

@shortcuts
Copy link
Member

The CTS should be aware of that change too, the client test for monitoring is not correct right now

I don't think we assert hosts yet but we can add one of course

@millotp
Copy link
Collaborator

millotp commented Jan 18, 2024

I don't think we assert hosts yet

yes we do ! in all clients ! except monitoring

@shortcuts
Copy link
Member

I don't think we assert hosts yet

yes we do ! in all clients ! except monitoring

:ah: let's fix that once all clients have implemented the uniqueHost so we don't have to block everyone until they fix their CTS

@shortcuts shortcuts merged commit 204ace7 into main Jan 18, 2024
28 checks passed
@shortcuts shortcuts deleted the fix-unique-server branch January 18, 2024 09:55
This was referenced Jan 18, 2024
Merged
Merged
Merged
@algolia-bot algolia-bot mentioned this pull request Jan 23, 2024
Closed
@shortcuts shortcuts mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fluf22 Fluf22 Fluf22 approved these changes

@millotp millotp Awaiting requested review from millotp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@morganleroi @algolia-bot @shortcuts @millotp @Fluf22