Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): provide non clashing names for custom methods #2369

Merged
merged 14 commits into from
Dec 12, 2023
Merged

fix(specs): provide non clashing names for custom methods #2369

merged 14 commits into from
Dec 12, 2023

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Dec 11, 2023 •
edited
Loading

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

The current name of the custom methods can clash with reserved keywords of certain languages (e.g. del for python). This PR proposes a custom prefix to those method names.

since Dart is already released, we provide the old methods as helpers with a deprecated warning. They still leverage the custom methods under the hood.

@shortcuts shortcuts self-assigned this Dec 11, 2023
@shortcuts shortcuts requested a review from a team as a code owner December 11, 2023 15:14
@netlify Netlify
Copy link

netlify bot commented Dec 11, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 999fa6c
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65787188e008e10008ff65d2
😎 Deploy Preview https://deploy-preview-2369--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Dec 11, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Fluf22
Fluf22 previously approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🆗

millotp
millotp reviewed Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great ! small comment about dart, I though we included the custom requests for algoliasearch too

templates/dart/api.mustache Show resolved Hide resolved
@shortcuts shortcuts requested a review from millotp December 12, 2023 09:38
@shortcuts shortcuts mentioned this pull request Dec 12, 2023
Merged
@shortcuts shortcuts enabled auto-merge (squash) December 12, 2023 14:31
@shortcuts shortcuts disabled auto-merge December 12, 2023 14:32
@shortcuts shortcuts enabled auto-merge (squash) December 12, 2023 14:43
@shortcuts shortcuts merged commit 8d71c2b into main Dec 12, 2023
24 checks passed
@shortcuts shortcuts deleted the fix/custom-methods branch December 12, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

@Fluf22 Fluf22 Awaiting requested review from Fluf22

@aallam aallam Awaiting requested review from aallam

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shortcuts @algolia-bot @Fluf22 @millotp