Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(go): release process for generated go client #1512

Merged
merged 4 commits into from
May 9, 2023

Conversation

mehmetaligok
Copy link
Contributor

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-662

Changes included:

  • Github action which will run on the next branch for the client repo is created.
  • Proper README.md is prepared to put in the generated code.

🧪 Test

It will be tested with https://github.com/algolia/algoliasearch-client-go/tree/next action.

@mehmetaligok mehmetaligok added the Go label May 5, 2023
@mehmetaligok mehmetaligok self-assigned this May 5, 2023
@netlify
Copy link

netlify bot commented May 5, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit d3546c6
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/645a16d2ef35210008bfb118
😎 Deploy Preview https://deploy-preview-1512--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented May 5, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@mehmetaligok mehmetaligok marked this pull request as ready for review May 5, 2023 13:40
@mehmetaligok mehmetaligok requested a review from a team as a code owner May 5, 2023 13:40
@mehmetaligok mehmetaligok requested review from aallam and shortcuts May 5, 2023 13:40
@millotp
Copy link
Collaborator

millotp commented May 9, 2023

I don't know where @shortcuts stores his script, but can you use the one he gave you to keep the history on the next branch pls ?

@mehmetaligok
Copy link
Contributor Author

@millotp I believe you are mentioning this https://algolia.atlassian.net/wiki/spaces/DA/pages/4129849375/How+to+setup+next+branch+for+the+generated+repository .

I already did that and generated the next branch. I checked with @shortcuts and he said the next branch is okay. As far as I understand this process is needed once and it looks already done.

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good !

@mehmetaligok mehmetaligok enabled auto-merge (squash) May 9, 2023 09:24
@mehmetaligok mehmetaligok merged commit 57b5918 into main May 9, 2023
@mehmetaligok mehmetaligok deleted the feat/go-client-release-pipeline branch May 9, 2023 09:53
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request May 9, 2023
algolia/api-clients-automation#1512

Co-authored-by: Mehmet Ali Gok <33124154+mehmetaligok@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants