Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sync opt to be selectable for auto setting update logic #425

Merged
merged 7 commits into from
May 17, 2022
Merged

fix: make sync opt to be selectable for auto setting update logic #425

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5cb61e0
fix: make sync opt to be selectable for auto setting update logic
kiyohara Mar 31, 2022
2d92839
Merge branch 'master' into fix/make_sync_opt_to_be_selectable_for_aut…
DevinCodes Apr 8, 2022
a722647
add specs
kiyohara Apr 11, 2022
50e6171
Merge branch 'master' into fix/make_sync_opt_to_be_selectable_for_aut…
DevinCodes Apr 15, 2022
79577ca
fix meaningless tests (add cache avoiding)
kiyohara Apr 15, 2022
d7d8552
Merge branch 'fix/make_sync_opt_to_be_selectable_for_auto_setting_upd…
kiyohara Apr 15, 2022
8ea6d0d
fix test point (change from set_setting! to wait_task)
kiyohara May 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/algoliasearch-rails.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,7 +800,8 @@ def algolia_ensure_init(options = nil, settings = nil, index_settings = nil)
replicas = index_settings.delete(:replicas) ||
index_settings.delete('replicas')
index_settings[:replicas] = replicas unless replicas.nil? || options[:inherit]
@algolia_indexes[settings].set_settings!(index_settings)
set_settings_method = options[:synchronous] ? :set_settings! : :set_settings
@algolia_indexes[settings].send(set_settings_method, index_settings)
end

@algolia_indexes[settings]
Expand Down