Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algolia v2 symbolizes keys #403

Merged
merged 3 commits into from
Aug 9, 2021

Conversation

bvogel
Copy link
Contributor

@bvogel bvogel commented Jul 22, 2021

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related Issue None
Need Doc update yes

Describe your change

force the setting of symbolize_keys: false as this project breaks without this setting

What problem is this fixing?

undefined method .map for nil in https://github.com/algolia/algoliasearch-rails/blob/master/lib/algoliasearch-rails.rb#L690

bvogel added 2 commits July 22, 2021 13:33
Signed-off-by: Burkhard Vogel-Kreykenbohm <bvk@capinside.com>
Signed-off-by: Burkhard Vogel-Kreykenbohm <bvk@capinside.com>
@bvogel
Copy link
Contributor Author

bvogel commented Jul 28, 2021

@DevinCodes if you could take a look at this once you're back from vacation, this would be very much appreciated.

@DevinCodes DevinCodes self-requested a review August 9, 2021 09:51
Copy link
Contributor

@DevinCodes DevinCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bvogel ! I'll try to release this later today.

@DevinCodes DevinCodes merged commit 171b1f6 into algolia:master Aug 9, 2021
@DevinCodes
Copy link
Contributor

This is out in v2.1.2. Thank you again!

@bvogel
Copy link
Contributor Author

bvogel commented Aug 10, 2021

Thank you to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants