Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @algolia/autocomplete-js to v1.0.0-alpha.45 #267

Merged
merged 7 commits into from
Apr 21, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 17, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@algolia/autocomplete-js 1.0.0-alpha.44 -> 1.0.0-alpha.45 age adoption passing confidence

Release Notes

algolia/autocomplete.js

v1.0.0-alpha.45

Compare Source

Bug Fixes
  • js: change button class name to "aa-ClearButton" (5991e77)
  • js: prevent id incrementation when toggling detached mode (#​489) (fe2bf13)
  • js: remove window references (#​501) (7628d09)
  • js: run reactive values only once (8356031)
  • qs: rename categoriesLimit to itemsWithCategories (#​491) (4c97375)
Features

Configuration

📅 Schedule: "every weekend" in timezone Europe/Paris.

🚦 Automerge: Disabled due to failing status checks.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/algolia-autocomplete-js-1.x branch 8 times, most recently from e163c2d to 7a4e380 Compare April 17, 2021 18:28
@renovate renovate bot force-pushed the renovate/algolia-autocomplete-js-1.x branch from 7a4e380 to ecd353f Compare April 17, 2021 22:33
@sbellone
Copy link
Collaborator

Moved function getSuggestionSnippet and getHighlightedHierarchy to templates.tsx to use the new Component API instead of the removed snippetHit() and highlightHit() functions.

We now pass directly the item and the components to templates.tsx which is in charge of all the rendering.

I haven't found what to change in ESLint config to remove the no-undef errors, I've put it in warning only.

@sbellone sbellone self-assigned this Apr 19, 2021
Copy link
Contributor

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems correct, however there is are regressions in the box shadow, the padding in the menu, and around the icons too

Screen Shot 2021-04-19 at 17 32 19

@sbellone
Copy link
Collaborator

sbellone commented Apr 19, 2021

Ok this was due to the theme changes done here: algolia/autocomplete#497

I hadn't noticed them because if you hit 127.0.0.1:9000 instead of localhost:9000, the checkIfWebpackRunning() check fails because of CORS and loads the jsdeliver.net CSS.

@bodinsamuel
Copy link
Contributor

bodinsamuel commented Apr 20, 2021

There is still a regression on padding and button being too big

Screen Shot 2021-04-20 at 13 33 22

---

Screen Shot 2021-04-20 at 13 33 14

@sbellone sbellone merged commit fcd5c34 into master Apr 21, 2021
@sbellone sbellone deleted the renovate/algolia-autocomplete-js-1.x branch April 21, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants