Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): remove invalid maxFacetHits in SearchForHits extension #153

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

dhayab
Copy link
Member

@dhayab dhayab commented Jan 8, 2025

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related Issue Fix #151
Need Doc update no

Describe your change

This PR removes an invalid search parameters applied to SearchForHits. The typing has been removed in algoliasearch-client-dart@1.27.2, preventing users from building their implementation when updating to this version.

@dhayab dhayab changed the title Fix/remove maxfacethits from searchforhits fix(client): remove invalid maxFacetHits in SearchForHits extension Jan 8, 2025
@dhayab dhayab requested review from aallam and Haroenv January 8, 2025 17:45
@dhayab dhayab merged commit 8afe98d into main Jan 9, 2025
6 checks passed
@dhayab dhayab deleted the fix/remove-maxfacethits-from-searchforhits branch January 9, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: No named parameter with the name 'maxFacetHits'. maxFacetHits: maxFacetHits
2 participants