chore(recommendation): rename RecommendationClient to PersonalizationClient
#536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
shortcuts
commented
Sep 23, 2021
•
shortcuts
commented
| Q | A |
|---|---|
| Bug fix? | fixes #530 |
| New feature? | yes |
| BC breaks? | no |
| Related Issue | no |
| Need Doc update | yes |
shortcuts
force-pushed
the
chore/rename-recommendation-client
branch
from
148ca43 to
e83269b
Compare
DevinCodes
approved these changes
Sep 28, 2021
There was a problem hiding this comment.
This looks good to me, but let's wait with merging until @tkrugg approves as well: I don't know any Python 😄
Sure, make sense! It's mostly copying + renaming and add warnings |
tkrugg
approved these changes
Oct 6, 2021
shortcuts
added a commit
that referenced
this pull request
Feb 24, 2023
…sonalization` (#554) | Q | A | ----------------- | ---------- | Bug fix? | no | New feature? | no | BC breaks? | yes | Related Issue | Fix #... <!-- will close issue automatically, if any --> | Need Doc update | no ## Describe your change https://algolia.atlassian.net/browse/DI-1010 ~Months~ years ago we added a deprecation notice for the recommendation client, since we will now release a new major, we can remove anything related to this client. deprecation PR #536
shortcuts
pushed a commit
that referenced
this pull request
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.