Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply attributesToRetrieve parameter to each request created by index.get_objects #424

Merged
merged 1 commit into from
May 28, 2019
Merged

Apply attributesToRetrieve parameter to each request created by index.get_objects #424

merged 1 commit into from
May 28, 2019

Conversation

msdinit
Copy link

@msdinit msdinit commented May 23, 2019

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related Issue n/a
Need Doc update no

Describe your change

Pop attributesToRetrieve from request_options before iterating over object_ids in order to ensure that:

  1. it's applied to each request created by the function
  2. it's not present in the main request parameters

What problem is this fixing?

Without this or a similar change, attributesToRetrieve is only applied to the first object, all other objects are retrieved with all attributes

nunomaduro
nunomaduro approved these changes May 28, 2019
View reviewed changes
Copy link

@nunomaduro nunomaduro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great pull request! Thanks!

@nunomaduro nunomaduro merged commit 759818f into algolia:master May 28, 2019
@nunomaduro
Copy link

This version 2.0.3 has been released and contains this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunomaduro nunomaduro nunomaduro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msdinit @nunomaduro