fix(bank-user): changed names of some API functions

algoan · Jul 9, 2020 · 9ed6a3c · 9ed6a3c
1 parent 21ef5c8
commit 9ed6a3c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/core/BanksUser.ts b/src/core/BanksUser.ts
@@ -94,7 +94,7 @@ export class BanksUser {
    *
    * @returns Array of BanksUserAccount
    */
-  public static async getAccountsByID(id: string, requestBuilder: RequestBuilder): Promise<BanksUserAccount[]> {
+  public static async getAccounts(id: string, requestBuilder: RequestBuilder): Promise<BanksUserAccount[]> {
     const accounts: BanksUserAccount[] = await requestBuilder.request({
       url: `/v1/banks-users/${id}/accounts`,
       method: 'GET',
@@ -112,7 +112,7 @@ export class BanksUser {
    *
    * @returns Array of BanksUserTransaction
    */
-  public static async getTransactionsByIds(
+  public static async getTransactionsPerAccounts(
     bankUserId: string,
     accountId: string,
     requestBuilder: RequestBuilder,

diff --git a/test/bank-user.test.ts b/test/bank-user.test.ts
@@ -52,7 +52,7 @@ describe('Tests related to the BanksUser class', () => {
     });
   });
 
-  describe('static getAccountsByID()', () => {
+  describe('static getAccounts()', () => {
     beforeEach(() => {
       banksUserAPI = getFakeAlgoanServer({
         baseUrl,
@@ -62,13 +62,13 @@ describe('Tests related to the BanksUser class', () => {
       });
     });
     it('should get the Banks User account', async () => {
-      const accounts: BanksUserAccount[] = await BanksUser.getAccountsByID('id1', requestBuilder);
+      const accounts: BanksUserAccount[] = await BanksUser.getAccounts('id1', requestBuilder);
       expect(banksUserAPI.isDone()).toBeTruthy();
       expect(accounts).toMatchObject([banksUserAccountSample]);
     });
   });
 
-  describe('static getTransactionsByIds()', () => {
+  describe('static getTransactionsPerAccounts()', () => {
     beforeEach(() => {
       banksUserAPI = getFakeAlgoanServer({
         baseUrl,
@@ -78,7 +78,7 @@ describe('Tests related to the BanksUser class', () => {
       });
     });
     it('should get the Banks User account', async () => {
-      const transactions: BanksUserTransaction[] = await BanksUser.getTransactionsByIds(
+      const transactions: BanksUserTransaction[] = await BanksUser.getTransactionsPerAccounts(
         'id1',
         'accountId1',
         requestBuilder,