Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Add logoUrl to bank #314

Merged
merged 1 commit into from
Sep 7, 2021
Merged

[FEAT] Add logoUrl to bank #314

merged 1 commit into from
Sep 7, 2021

Conversation

g-ongenae
Copy link
Member

  • Create a new function getBankInformation to retrieve the logo_url of the bank
  • Remove the BridgeBank retrieval from the getResourcesName

Reference

ccoeurderoy
ccoeurderoy approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@ccoeurderoy ccoeurderoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@meriamBenSassi meriamBenSassi merged commit f799483 into algoan:master Sep 7, 2021
@algoanbot
Copy link

🎉 This PR is included in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@g-ongenae g-ongenae deleted the feature/add-logo-url-to-bank branch September 27, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccoeurderoy ccoeurderoy ccoeurderoy approved these changes

@meriamBenSassi meriamBenSassi meriamBenSassi approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@g-ongenae @algoanbot @ccoeurderoy @meriamBenSassi