Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyperlink text appears in white over flowchart #45

Closed
bijwaard opened this issue Oct 1, 2019 · 27 comments
Closed

hyperlink text appears in white over flowchart #45

bijwaard opened this issue Oct 1, 2019 · 27 comments
Labels
bug Something isn't working Fixed

Comments

@bijwaard
Copy link

bijwaard commented Oct 1, 2019

Hi Arnaud,
I created two links in my flowcharting diagram, one via draw.io on the logo icon, and one via a rule on the business building icon. Both are shown in white over the diagram, both when editing rules (first figure, below its icons) and also when in view mode (second figure, once on the right of logo icon, three times on the right&above building icon).

This started after using the inspector, I only seem to be able to get rid of it by re-loading the grafana web-page.

Kind regards,
Dennis
image
image

@algenty
Copy link
Owner

algenty commented Oct 1, 2019

Hi Dennis,
I know this bug, for me it's only during the conception , if you save and reload, the text disappears.
i need more test for this bug

BR

@algenty algenty added the bug Something isn't working label Oct 1, 2019
@bijwaard
Copy link
Author

bijwaard commented Oct 1, 2019

It seems to be related to the inspector, after page reload and using the inspector for the relevant icons the white hyperlinks appeared again.

@bijwaard
Copy link
Author

bijwaard commented Oct 1, 2019

Also just happened while adding a link to a rule.

@bijwaard
Copy link
Author

bijwaard commented Oct 1, 2019

As a side node, only the first link (CT2:L1) has an active hyperlink when I configure multiple link mappings. The other 3 are not clickable.
image

@algenty
Copy link
Owner

algenty commented Oct 1, 2019

Which version do you use?
0.5.0 fix some problems with links

@bijwaard
Copy link
Author

bijwaard commented Oct 1, 2019

This is with the 0.40 release, I look forward to the 0.50 fixes;-)

@algenty
Copy link
Owner

algenty commented Oct 3, 2019

Dennis,
any news ?

@bijwaard
Copy link
Author

bijwaard commented Oct 3, 2019

No more news for these bugs, both white hyperlinks and multi-link mappings problems are still there.
Just retried in the 0.5.0 snapshot, white hyperlinks still don't go away after meddling with links in edit mode, the multi-link mappings are still not working for other than first mapping.

@algenty
Copy link
Owner

algenty commented Oct 5, 2019

fixed in lat 0.5.0

@algenty algenty added the Fixed label Oct 5, 2019
@bijwaard
Copy link
Author

bijwaard commented Oct 5, 2019

Hi Arnaud,
Great, the white hyperlink happens less frequent now. However, I still get it when I quickly hover over the link mapping IDs a number of times.
Kind regards,
Dennis

@bijwaard
Copy link
Author

bijwaard commented Oct 6, 2019

Hi Arnaud,
I apparently didn't install the snapshot properly, I had multiple versions with different names in /var/lib/grafana/plugins. I now moved away the 0.4.0 version, restarted grafana and the multiple links work as well as the variable selection. Great work!!
Dennis

@algenty
Copy link
Owner

algenty commented Oct 6, 2019

next snapshot doesn't reset zoom when datas refreshed
it coming soon, i need you to test it, you are my favorite tester :)

@bijwaard
Copy link
Author

bijwaard commented Oct 6, 2019

Hi Arnaud,
I'ld be happy to test it, it would improve zoom functionality, I guess I noticed this issue some time ago while testing zoom.
Kind regards,
Dennis

@algenty
Copy link
Owner

algenty commented Oct 8, 2019

Hi dennis,
Zoom fixed in last snapshot

Arnaud

@bijwaard
Copy link
Author

bijwaard commented Oct 8, 2019

Hi Arnaud,
Zoom level now persists when dashboard refreshes its metrics, tested in firefox with double-click zoom, and in chromium with most zoom-abilities. Great work!
Some related issues:

  • zooming with mouse still doesn't work in firefox, all icons disappear as commented earlier in one of the zoom-related tickets.
  • Variable selection resets the zoom level.
  • mouse-wheel scroll and scrollbars have some weird side-effects in chrome&firefox with the background, see figure below. A partly transparent background (as configured in draw.io) is shown instead of the configured light-blue background under flowcharting.

Kind regards,
Dennis
image

@algenty
Copy link
Owner

algenty commented Oct 9, 2019

hi Dennis
thx for your feebacks
i kowns these problems when scale is on
i'll try to correct it

br
Arnaud

@algenty
Copy link
Owner

algenty commented Oct 9, 2019

Zoom et background resoved in last snapshot

@bijwaard
Copy link
Author

Hi Arnaud,
After double click I cannot scroll anymore, no wonder that the background issue does not appear anymore. I liked being able to scroll through the rest of the flowchart after zoom, especially on firefox where I cannot (yet) zoom with the mouse because all graphics get lost. Now I have to create a number of areas in draw.io to zoom to...
Kind regards,
Dennis

@algenty
Copy link
Owner

algenty commented Oct 10, 2019

thx for this feedback

@algenty
Copy link
Owner

algenty commented Oct 12, 2019

I share a screenshot of next version, not available at the moment, maybe this week-end
tooltip_graph_ani_2

@bijwaard
Copy link
Author

bijwaard commented Oct 12, 2019 via email

@algenty
Copy link
Owner

algenty commented Oct 13, 2019

Hi Dennis,
This version is available in download section. i've fixed zoom in firefox and edge.
tooltip_graph

https://twitter.com/gf_flowcharting/status/1183386365175746562

BR

@bijwaard
Copy link
Author

bijwaard commented Oct 13, 2019

Hi Arnaud,

The graph tooltips work like a charm on graph icons! Also mouse-zooming in firefox works. You've been busy, good work!

The tooltips however do not seem to work on lines connecting icons, such as the line from the switchbox above to the CT:L3 with 749.9W, just above the one that now shows its tooltip & graph.

Btw. I wonder how you manage to show multiple graphs in one tooltip.
Btw. I wonder if it is possible to do scaling with respect to current values instead of from 0, e.g. voltage varies between 210V and 250V but I only see a flatline, since the graph in the tooltip seems to have 0-250V on the Y axis. When scaling to the value range it would also be more prominent to show the range values on the Y axis

image

Kind regards,
Dennis

@algenty
Copy link
Owner

algenty commented Oct 13, 2019

Yeah !!! it's fantastic
Thanks for this first feedback !! I am very happy
I add "scaling for Y value" on roadmap.
I dont understand why it not work on line or arrow, i'll try it

To show multi graph in the same tooltip, you need multi rules/series on the same object.
I don't understand the graph, it's your home ?

BR,
Arnaud
PS : Can i use your screenshot for twitter ?

@bijwaard
Copy link
Author

Hi Arnaud,
The graph is indeed a lab-home with a 3-phase power connection to the grid at the top and a single-phase and tri-phase inverter at the bottom all measured with our LV-Sensors. Next step in the United-Grid project is to also measure the substation;-) In the substation, multi-rules/series and tooltip graphs would be very nice.

Yes you can use my screenshot for twitter.

Kind regards,
Dennis

@bijwaard
Copy link
Author

bijwaard commented Oct 14, 2019

Hi Arnaud,
I'm having some trouble getting the multi-metric graphs to work. I've added a regex that selects 3 metrics in the Business rule (/CT:P_L[123]-active/), I now see 4 values in my chart above the office icon where the top-one was the old value before changing the regex (I could change this to some text in draw.io), and I only see one graph for the third metric (bottom value above office icon is same as in graph).
I tried fiddling with grouping in the metrics regex and tried to re-use them in the tooltip label, but this doesn't seem to work, e.g. metric /(CT:P_L[123]-active)/ and label \1, empty label doesn't show label in tooltip
Kind regards,
Dennis
image

@algenty
Copy link
Owner

algenty commented Oct 14, 2019

Ok, i understand. I'll try to fix it
it works if you have 4 rules (1 rule : 1 value) instead 1 rules 4 values
Graph is based on the name of label (uniq), each value replace the previous value and graph becaus label is the same.
Its a good issue for me, I never thought you could use flowcharting like that.
Can you create a new issue for it ?

BR
Arnaud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fixed
Projects
None yet
Development

No branches or pull requests

2 participants