Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle zero ideal cases #76

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Conversation

rprebet
Copy link
Contributor

@rprebet rprebet commented Sep 16, 2024

Handle the cases where a GB of the zero ideal is output. More precisely when

  • the input polynomials array is empty or contains only zeros;
  • the elimination ideal is the zero ideal.

This assumes the convention that the GB of the zero ideal is the empty set, following Cox, Little & O'Shea.

@rprebet
Copy link
Contributor Author

rprebet commented Sep 16, 2024

The tests seems to require the GB of the zero ideal to be [0] so I adapted the code.
This cannot be done however, whenever the input ideal generators is an empty list.

@mohabsafey mohabsafey merged commit 5c1ba82 into algebraic-solving:main Sep 17, 2024
8 checks passed
@rprebet rprebet deleted the specialcaseGB branch September 30, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants