Skip to content

Commit

Permalink
Merge pull request #72 from ederc/new-release
Browse files Browse the repository at this point in the history 
Preparing v0.6.1
  • Loading branch information
@ederc
ederc authored Aug 2, 2024
2 parents a47f995 + 279d71d commit 09ecdea
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "AlgebraicSolving"
uuid = "66b61cbe-0446-4d5d-9090-1ff510639f9d"
authors = ["ederc <ederc@mathematik.uni-kl.de>", "Mohab Safey El Din <Mohab.Safey@lip6.fr", "Rafael Mohr <rafael.mohr@lip6.fr>"]
version = "0.6.0"
version = "0.6.1"

[deps]
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
Expand Down
10 changes: 8 additions & 2 deletions src/algorithms/groebner-bases.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,9 @@ function _core_groebner_basis(

F = I.gens
R = first(F).parent
if F == [R(0)]

if F == repeat([R(0)], length(F))
I.gb[eliminate] = F
return F
end
nr_vars = nvars(R)
Expand All @@ -164,7 +166,6 @@ function _core_groebner_basis(
error("Number of variables to be eliminated is bigger than number of variables in ring.")
end
reduce_gb = Int(complete_reduction)

# convert ideal to flattened arrays of ints

if !(field_char == 0)
Expand All @@ -176,6 +177,11 @@ function _core_groebner_basis(
# nr_gens might change if F contains zero polynomials
lens, cfs, exps, nr_gens = _convert_to_msolve(F)

# recheck if all input data is invalid
if nr_gens == 0
I.gb[eliminate] = F
return I.gb[eliminate]
end
gb_ld = Ref(Cint(0))
gb_len = Ref(Ptr{Cint}(0))
gb_exp = Ref(Ptr{Cint}(0))
Expand Down

2 comments on commit 09ecdea

@ederc
Copy link
Collaborator Author

@ederc ederc commented on 09ecdea Aug 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/112273

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.6.1 -m "<description of version>" 09ecdeabd4d7e0ca09eb238060ec520db824371a
git push origin v0.6.1

Please sign in to comment.