Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set upper limit of time spent in waiting room #66

Closed

Conversation

nspo
Copy link

@nspo nspo commented Jun 12, 2021

While I understand that you do not consider #60 a bug, I think it would still be a great feature if you were able to set an upper limit for the time spent in the waiting room of one location. I had a situation where the waiting room took much longer than 10 min to go away, and I'd think most users would want to continue to other locations in that case.

@nspo
Copy link
Author

nspo commented Jun 12, 2021

Just saw this: #1 (comment)

Can you explain why aborting the waiting room wait after e.g. 10 min might lead to more shadow bans? If so, the default could still be set to inf or some high value

As a note: I think not caring about the waiting room makes most sense if you use the parallel workers and always check the same location. If you use sequential crawling, it will stop everything :/

@alfonsrv
Copy link
Owner

alfonsrv commented Jun 13, 2021

Hey @nspo, thanks for your PR!

Waiting rooms are not infinite, so I don't see a benefit of adding an upper limit.

Possibly increasing shadow bans is just an assumption. If you make too many requests too aggressively and simply bounce between centers it might stick out – the bot is currently geared to blending in with the crowd.

Every added setting should solve a challenge of the platform. This is because new users need to rely on believing exactly that, assuming every setting is there for a reason – so there's an obligation to not add / promote unbeneficial use-cases. The comment asked for a way to skip the location straight away if a waiting room appeared. Adding a setting like that could thus lead inexperienced users to believing Waiting rooms should be avoided at all cost, instead of just being a minor inconvenience of the overall process. On a technical level, this could've also ended up in the bot only jumping around centers indefinitely, causing for the upmost frustration for users besides the possible increase in shadow bans.

BR, Alfons

@alfonsrv
Copy link
Owner

Closing due to inactivity.

@alfonsrv alfonsrv closed this Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants