-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When calling exit(), added call to phantom.kill() #25
base: master
Are you sure you want to change the base?
Conversation
oh thank god. that explains why phantom never dies for me. |
This does not work for me. Normally all PhantomJS instances exit correctly for me, but if I include this they stop exiting. Which platform are you on? |
Thanks for responding, Alex. I'm on RHEL6. @delvarworld - How about you? |
CentOS 6(RHEL 6) here -- Same issue. But, I assumed it was because I haven't figured out how to add a timeout to the phantom object. |
I see this, too: Phantom never dies. On OS X, using 1.8.1. |
Also using 1.8.1 on osx |
This line fixes phantom process not exiting for me
|
I think one need to wait for the kill event to be send. |
having the same problem on The instances are draining a lot of cpu as well from what I can see in Its the bridge.js that has started them from what I can see with |
The fix doesn't work for me. I think I get a script error in phantom that crashes phantom silently. The phantom-process is never killed |
Whew, just spent hours wondering why I was spawning off phantomjs zombie processes. Fix works for me - I can't modify the node-phantom code so I'm working around it by using:
|
shouldn't the right place to put this be line 141: ?
|
Calling exit() doesn't terminate the spawned process. So I added a call to phantom.kill() to do the trick.
Fixes #24