Flatten mod scoping into root

[bheylin]

mod scoping is adding an unnecessary level to the mod hierarchy. It is true that the sub-modules are involved in 'scoping', but does that need to be taxonimized into the mod hierarchy? I argue that flattening the mod scoping into the parent mod reduces the complexity of the hierarchy without lossing meaning.

[alexpovel]

Sorry, I don't think I can agree. There's the two big themes of "actions" and "scoping" to srgn. While those are primarily end user-facing, I agree that doesn't necessarily have to be reflected in the source code, but why not? I don't see how it hurts.

Imports paths like use crate::scoping::scope::ScopeContext; are a bit crappy, I agree. That could be shortened to use crate::scoping::ScopeContext;, for example. However, the other paths make sense to me: there's scoping::regex, so that's clearly for scoping and not an action, or something auxiliary. Now there's just src/regex.rs, which loses that meaning. One could argue: Why not also flatten all actions as well at this point? That would be in the same spirit IIUC, but then it becomes pretty cluttered.

And languages are just a subcategory of scoping, which also makes sense in my mind. For example, it allows us to keep things like LanguageScoper in langs.rs.

[bheylin]

Sorry, I don't think I can agree.

No need to be sorry, this is just how I try out ideas. I just make a PR and discuss it with the knowledge that it can be closed. I can handle being told "no" 😆

There's the two big themes of "actions" and "scoping" to srgn. While those are primarily end user-facing, I agree that doesn't necessarily have to be reflected in the source code, but why not? I don't see how it hurts.

Imports paths like use crate::scoping::scope::ScopeContext; are a bit crappy, I agree. That could be shortened to use crate::scoping::ScopeContext;, for example. However, the other paths make sense to me: there's scoping::regex, so that's clearly for scoping and not an action, or something auxiliary. Now there's just src/regex.rs, which loses that meaning. One could argue: Why not also flatten all actions as well at this point? That would be in the same spirit IIUC, but then it becomes pretty cluttered.

And languages are just a subcategory of scoping, which also makes sense in my mind. For example, it allows us to keep things like LanguageScoper in langs.rs.

The translation of taxonomic subcategories into namespaces is what I'm questioning.
But this is a suggestion, not something I feel strongly about.

The lang mod doesn't add value for me. LanguageScoper can just as easily live in scoping.rs and make as much sense.
If you apply the moduly_name_repetition clippy strictly. Types should not use the mod name as a prefix or postfix.
I take the view that the lang::LanguageScoper mod name repetition is a hint that it's in an overly specified/taxonimized namespace.

Maybe we could flatten langs into scoping?
If not, then I'll close the PR.

[alexpovel]

Maybe we could flatten langs into scoping?

That we could do, yes. Having e.g. python live next to regex is fine, or LanguageScoper directly in scoping.rs.