Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure with 3.12.5 #82

Closed
s-t-e-v-e-n-k opened this issue Aug 16, 2024 · 1 comment · Fixed by #83
Closed

Failure with 3.12.5 #82

s-t-e-v-e-n-k opened this issue Aug 16, 2024 · 1 comment · Fixed by #83
Assignees
@15r10nk

Comments

@s-t-e-v-e-n-k
Copy link

s-t-e-v-e-n-k commented Aug 16, 2024 •
edited
Loading 

[   22s] Traceback (most recent call last):
[   22s]   File "/home/abuild/rpmbuild/BUILD/executing-2.0.1/tests/test_main.py", line 604, in test_iter
[   22s]     for i in iter_test(ast.For):
[   22s]              ^^^^^^^^^^^^^^^^^^
[   22s]   File "/home/abuild/rpmbuild/BUILD/executing-2.0.1/tests/test_main.py", line 587, in __iter__
[   22s]     assert isinstance(calling_expression(), self.typ)
[   22s]                       ^^^^^^^^^^^^^^^^^^^^
[   22s]   File "/home/abuild/rpmbuild/BUILD/executing-2.0.1/tests/test_main.py", line 48, in calling_expression
[   22s]     return Source.executing(frame).node
[   22s]            ^^^^^^^^^^^^^^^^^^^^^^^
[   22s]   File "/home/abuild/rpmbuild/BUILD/executing-2.0.1/executing/executing.py", line 273, in executing
[   22s]     node_finder = NodeFinder(frame, stmts, tree, lasti, source)
[   22s]                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[   22s]   File "/home/abuild/rpmbuild/BUILD/executing-2.0.1/executing/_position_node_finder.py", line 165, in __init__
[   22s]     self.verify(self.result, self.instruction(lasti))
[   22s]   File "/home/abuild/rpmbuild/BUILD/executing-2.0.1/executing/_position_node_finder.py", line 772, in verify
[   22s]     raise VerifierFailure(title, node, instruction)
[   22s] executing._exceptions.VerifierFailure: ast.Call is not created from GET_ITER

The above test works fine with 3.12.4, but gives the following traceback under 3.12.5.
@15r10nk
Copy link
Collaborator

15r10nk commented Aug 16, 2024

I will take a look at it

@15r10nk 15r10nk self-assigned this Aug 16, 2024
15r10nk added a commit that referenced this issue Aug 16, 2024
@15r10nk
fix: backward compatibility fix for changed source positions in 3.12.5 (
0b91387 
#82)
@15r10nk 15r10nk mentioned this issue Aug 17, 2024
Merged
15r10nk added a commit that referenced this issue Aug 25, 2024
@15r10nk
fix: backward compatibility fix for changed source positions in 3.12.5 (
230ef11 
#82) (#83)

* fix: backward compatibility fix for changed source positions in 3.12.5 (#82)

* feat!: dropped support for 3.5, 3.6 and 3.7

* test: skip module tests for python.py

* refactor: review changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@15r10nk 15r10nk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: backward compatibility fix for changed source positions in 3.12.5 (#82) alexmojaki/executing
2 participants
@s-t-e-v-e-n-k @15r10nk