-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom logger #3
Conversation
Thanks for submitting your PR, I will have a look later today! 🙏 |
Hi @Pfeifenjoy just added small changes to your PR:
Let me know if it fits your purpose and then I can approve and merge it! tks! |
Hi @alexmarqs sounds cool, I am of course good with it. Yeah the build was fucking me up a bit, was not sure if you wanted to stay with pnpm. I am thinking about changing this a bit because my intention was to have the adapters fail silently. That can also be done by leaving the warn log function empty but I am not sure if that is a good approach or if it is better to add the option "silent" to the adapters. Let me know of your opinion. |
Hi @Pfeifenjoy , actually why not both 🤔 ? Last night drafted something about your suggestion, see PR changes.(introduced a silentFail for the adapters, maybe we could also have a generic/config level that would apply this setting for all adapters, but I think having it per adapter should be fine for now). Cheers, let me know your feedback! |
I will merge this later today as I think it introduces some small cool features to next release, thanks for the contribution. In the meantime let me know if this fits your use case or if you would like to see any other! If so, feel free to open a new issue or reach me out. Thanks. |
Released here. As usual, feel free to share any other suggestions or requests in a new issue. tks! |
Allow users to pass a custom logging function for warnings.