Making the name of the S3 backup directory configurable #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an environment variable
The script was looking at all of the files in the specified bucket when determining which ones to delete. I only want it to look under the designated backup directory, so I added the directory prefix when it's considering which files to delete.
|
Thanks a lot for this! Could you please add a passage to the README.md as well to keep documentation consistent, and add yourself to the end of the doc contributors section. Also bump gem version. Thank you! |
|
Updated the README and incremented the gem version. |
alexkravets
pushed a commit
that referenced
this pull request
Aug 11, 2013
Making the name of the S3 backup directory configurable
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Mongo backups are uploaded to S3, they're stored under the "backups" directory in the configured S3 bucket (i.e. the path to each backup is BUCKET/backups/YYYY-MM-DD_hh-mm-ss.gz).
I updated the module to allow you to configure the name of the directory in S3, so you can set it to a value other than "backups."
The directory name is configurable through any of the following environment variables:
The MAX_BACKUPS setting will respect the configured directory name, so it will only remove backups that match the given directory prefix.
My use case is that I have a single S3 bucket with hourly, daily, and monthly backups, and I wanted the directory names to reflect which type of backup was in each directory. I also have a different MAX_BACKUPS value for each type of backup.