Add auto-updating #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkim205
changed the title
alexkim205
added
enhancement
mding5692
reviewed
May 22, 2020
| @@ -78,6 +87,7 @@ | |||
| "del": "^5.1.0", | |||
| "electron": "^8.2.5", | |||
| "electron-builder": "^22.6.0", | |||
| "electron-log": "^4.1.4", | |||
There was a problem hiding this comment.
Probably want to remove dependencies from README and move it to a DEPENDENCIES.md file because might get to hard to manage listing all these dependencies
There was a problem hiding this comment.
This is a good point, however I don't think this is within the scope of this PR, so I'll create another PR just for reorganizing docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Resolves #63.
Solution
https://medium.com/@johndyer24/creating-and-deploying-an-auto-updating-electron-app-for-mac-and-windows-using-electron-builder-6a3982c0cee6
I also want to automate CI deployment of the cask. TODO: update the workflow to also update and push to
homebrew-cask.Before & After Screenshots
BEFORE:
[insert screenshot here]
AFTER:
[insert screenshot here]
Other changes (e.g. bug fixes, UI tweaks, small refactors)
Deploy Notes
Notes regarding deployment of the contained body of work. These should note any
new dependencies, new scripts, etc.
New environment variables:
GH_TOKEN: Required for CI publishing. Accessed inpackage.json.New scripts:
build: Build project but don't publish to Github.deploy: Build project and publish to Github.New dependencies:
electron-updater: [https://www.electron.build/auto-update][https://www.electron.build/auto-update]New dev dependencies:
electron-log: https://github.com/megahertz/electron-log