[Feature] Homepage API support #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulling changes from base repo.
Copying from henrywhitaker3/Speedtest-Tracker.
Copied from henrywhitaker3/Speedtest-Tracker
Copied from henrywhitaker3/Speedtest-Tracker
Copied from henrywhitaker3/Speedtest-Tracker
Homepage api
Simplifying
|
Thanks a ton for getting this going, I'm going to do some further changes to the PR. Mainly to simplify things even more... |
|
@cinderblockgames I pushed some code but it disappeared. Did it end up on your fork? |
|
I don't see it in mine. |
|
It made a branch on yours. |
Opened a PR on your fork so you can checkout the change |
refactored to more modern coding standards
|
@alexjustesen Works perfectly!
|
2 tasks
alexjustesen
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a condensed version of the code that was in the original app. All it does is add one controller file + reference it in the api spec. Can be used until the fully-featured API is ready.