Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require recipient Telegram and validate bot token #324

Merged
merged 9 commits into from
Jan 13, 2023
Merged

Require recipient Telegram and validate bot token #324

merged 9 commits into from
Jan 13, 2023

Conversation

garanda21
Copy link
Contributor

@garanda21 garanda21 commented Jan 13, 2023 •
edited
Loading

This request fix count against null object.

As a bonus I've added a validation in case the TELEGRAM_BOT_TOKEN is empty or missing, with this we avoid error 404 Chat not found

php artisan config:cache is necessary becase new files were created at /config folder

@garanda21 garanda21 mentioned this pull request Jan 13, 2023
Closed
alexjustesen
alexjustesen requested changes Jan 13, 2023
View reviewed changes
Copy link
Owner

@alexjustesen alexjustesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the validation, couple of things to adjust and make sure to run pint so code quality passes.

@alexjustesen alexjustesen added the 🐛 bug Something isn't working label Jan 13, 2023
@garanda21
Copy link
Contributor Author

Good catch on the validation, couple of things to adjust and make sure to run pint so code quality passes.

Submit new commit with changes! Let me know any other issues...

@alexjustesen alexjustesen merged commit bf56509 into alexjustesen:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjustesen alexjustesen alexjustesen approved these changes

Assignees

@garanda21 garanda21

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garanda21 @alexjustesen