-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the # of backups at each level configurable #31
Conversation
A setting of "0" means to keep indefinitely. With it now being done three times (adding in yearly), the deletion loop becomes repetitive. This commit factors it out into a function.
Using a common function for the deletion loop seems like a good idea even if the parameters aren't exposed. |
Instead of hostname-type-date- (or hostname-type-date-.), simply drop the -target entirely (hostname-type-date).
Would be nice to get working again. ``` $ go get -u mvdan.cc/sh/cmd/shfmt package mvdan.cc/sh/v3/fileutil: cannot find package "mvdan.cc/sh/v3/fileutil" in any of: /home/travis/.gimme/versions/go1.7.4.linux.amd64/src/mvdan.cc/sh/v3/fileutil (from $GOROOT) /home/travis/gopath/src/mvdan.cc/sh/v3/fileutil (from $GOPATH) package mvdan.cc/sh/v3/syntax: cannot find package "mvdan.cc/sh/v3/syntax" in any of: /home/travis/.gimme/versions/go1.7.4.linux.amd64/src/mvdan.cc/sh/v3/syntax (from $GOROOT) /home/travis/gopath/src/mvdan.cc/sh/v3/syntax (from $GOPATH) The command "go get -u mvdan.cc/sh/cmd/shfmt" failed and exited with 1 during . ```
I'm gradually working on a copy model that will obviate the need for the loop. It'll do a daily backup every time, and then use tarsnap's copy function to create monthly/yearly backups as needed. |
I saw that comment, sounds clever. I've just pushed a "fix" for Travis too,
which should help.
…On Tue, 11 Jun 2019 at 10:45, Adam Weinberger ***@***.***> wrote:
I'm gradually working on a copy model that will obviate the need for the
loop. It'll do a daily backup every time, and then use tarsnap's copy
function to create monthly/yearly backups as needed.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#31?email_source=notifications&email_token=AAC4U5MJFM23NIXEBJXXC7DPZ3YRNA5CNFSM4HWZPHXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXLTN4I#issuecomment-500643569>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC4U5IZZUBM32YRQA3XOOTPZ3YRNANCNFSM4HWZPHXA>
.
|
That's a lie. The copy model only affects backup, not pruning. This PR is completely separate. |
A setting of "0" means to keep indefinitely. With it now being done three times (adding in yearly), the deletion loop becomes repetitive. This commit factors it out into a function.
Instead of hostname-type-date- (or hostname-type-date-.), simply drop the -target entirely (hostname-type-date).
…into configurable_limits
There is another PR (#32) that deals with this. Let this PR just be about configurable limits.
And use awk, which avoids the weird spacing of `wc -l`
A value of 0 means to keep indefinitely.
I'm curious whether anybody else is into this idea. The defaults are so completely sensible that I'm not sure anybody else would be keen to change them.
A setting of "0" means to keep indefinitely.
With it now being done three times (adding in yearly), the
deletion loop becomes repetitive. This commit factors it
out into a function.