Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs around advanced orders and OCO/trigger #302

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

alexgolec
Copy link
Owner

Apparently composite orders no longer require Advanced Features to be disabled

Apparently composite orders no longer require Advanced Features to be disabled
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #302 (8c2d4cb) into master (1922c54) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #302   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files          19       19           
  Lines        2193     2193           
  Branches      306      306           
=======================================
  Hits         2184     2184           
  Misses          4        4           
  Partials        5        5           
Flag Coverage Δ
unittests 99.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1922c54...8c2d4cb. Read the comment docs.

@s-maheshbabu
Copy link
Contributor

There is this statement here.

This will also preclude you from placing complex orders, like 1 TRG OCO.

Should we remove that statement or make it less assertive?

@alexgolec
Copy link
Owner Author

I'm confused, that's a link to a different project

@s-maheshbabu
Copy link
Contributor

Oops, I mixed up things. I'm working with the other repo too and confused things :)
Sorry about that. Your current PR lgtm.

@alexgolec alexgolec merged commit 729dc42 into master Apr 8, 2022
@alexgolec alexgolec deleted the alexgolec-patch-1 branch April 8, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants