Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added asynchronous close method and updated documentation #211

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

alexgolec
Copy link
Owner

No description provided.

@alexgolec alexgolec linked an issue Apr 30, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #211 (8a080cf) into master (b4c62d2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #211   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files          17       17           
  Lines        1958     1960    +2     
  Branches      172      172           
=======================================
+ Hits         1949     1951    +2     
  Misses          4        4           
  Partials        5        5           
Flag Coverage Δ
unittests 99.54% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tda/client/asynchronous.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4c62d2...8a080cf. Read the comment docs.

@alexgolec alexgolec merged commit a80f8af into master Apr 30, 2021
@alexgolec alexgolec deleted the async-close branch April 30, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User warning on unclosed asynchronous client
1 participant