Skip to content

Commit

Permalink
tools: fix current version check
Browse files Browse the repository at this point in the history
PR-URL: nodejs#50951
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
marco-ippolito authored and pull[bot] committed Oct 15, 2024
1 parent 1589665 commit 8a6feab
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion tools/dep_updaters/update-acorn-walk.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ DEPS_DIR="$BASE_DIR/deps"
. "$BASE_DIR/tools/dep_updaters/utils.sh"

NEW_VERSION=$("$NODE" "$NPM" view acorn-walk dist-tags.latest)
CURRENT_VERSION=$("$NODE" "$NPM" --prefix './deps/acorn/acorn-walk/' pkg get version)
CURRENT_VERSION=$("$NODE" -p "require('./deps/acorn/acorn-walk/package.json').version")

# This function exit with 0 if new version and current version are the same
compare_dependency_version "acorn-walk" "$NEW_VERSION" "$CURRENT_VERSION"
Expand Down
2 changes: 1 addition & 1 deletion tools/dep_updaters/update-acorn.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ DEPS_DIR="$BASE_DIR/deps"
. "$BASE_DIR/tools/dep_updaters/utils.sh"

NEW_VERSION=$("$NODE" "$NPM" view acorn dist-tags.latest)
CURRENT_VERSION=$("$NODE" "$NPM" --prefix './deps/acorn/acorn/' pkg get version)
CURRENT_VERSION=$("$NODE" -p "require('./deps/acorn/acorn/package.json').version")

# This function exit with 0 if new version and current version are the same
compare_dependency_version "acorn" "$NEW_VERSION" "$CURRENT_VERSION"
Expand Down
2 changes: 1 addition & 1 deletion tools/dep_updaters/update-minimatch.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ NPM="$DEPS_DIR/npm/bin/npm-cli.js"
. "$BASE_DIR/tools/dep_updaters/utils.sh"

NEW_VERSION=$("$NODE" "$NPM" view minimatch dist-tags.latest)
CURRENT_VERSION=$("$NODE" "$NPM" --prefix './deps/minimatch' pkg get version)
CURRENT_VERSION=$("$NODE" -p "require('./deps/minimatch/package.json').version")

# This function exit with 0 if new version and current version are the same
compare_dependency_version "minimatch" "$NEW_VERSION" "$CURRENT_VERSION"
Expand Down

0 comments on commit 8a6feab

Please sign in to comment.