Skip to content

Commit

Permalink
fix(builtin): handle scoped packages in generated npm_umd_bundle targets
Browse files Browse the repository at this point in the history
  • Loading branch information
alexeagle committed Dec 5, 2019
1 parent f8035aa commit 967734f
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion internal/npm_install/generate_build_file.js
Original file line number Diff line number Diff line change
Expand Up @@ -873,7 +873,7 @@ node_module_library(
npm_umd_bundle(
name = "${pkg._name}__umd",
package_name = "${pkg._name}",
package_name = "${pkg._moduleName}",
entry_point = "//:node_modules/${pkg._dir}/${mainEntryPoint}",
package = ":${pkg._name}",
)
Expand Down
2 changes: 1 addition & 1 deletion internal/npm_install/generate_build_file.ts
Original file line number Diff line number Diff line change
Expand Up @@ -967,7 +967,7 @@ node_module_library(
npm_umd_bundle(
name = "${pkg._name}__umd",
package_name = "${pkg._name}",
package_name = "${pkg._moduleName}",
entry_point = "//:node_modules/${pkg._dir}/${mainEntryPoint}",
package = ":${pkg._name}",
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -760,7 +760,7 @@ node_module_library(
load("@build_bazel_rules_nodejs//internal/npm_install:npm_umd_bundle.bzl", "npm_umd_bundle")
npm_umd_bundle(
name = "core__umd",
package_name = "core",
package_name = "@angular/core",
entry_point = "//:node_modules/@angular/core/fesm5/core.js",
package = ":core",
)
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ node_module_library(
load("@build_bazel_rules_nodejs//internal/npm_install:npm_umd_bundle.bzl", "npm_umd_bundle")
npm_umd_bundle(
name = "test-a__umd",
package_name = "test-a",
package_name = "@gregmagolan/test-a",
entry_point = "//:node_modules/@gregmagolan/test-a/main.js",
package = ":test-a",
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ node_module_library(
load("@build_bazel_rules_nodejs//internal/npm_install:npm_umd_bundle.bzl", "npm_umd_bundle")
npm_umd_bundle(
name = "test-b__umd",
package_name = "test-b",
package_name = "@gregmagolan/test-b",
entry_point = "//:node_modules/@gregmagolan/test-b/main.js",
package = ":test-b",
)

0 comments on commit 967734f

Please sign in to comment.