Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

header needed for python scipy mmread compatibility #550

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

k3yavi
Copy link
Contributor

@k3yavi k3yavi commented Jan 25, 2019

No description provided.

@alexdobin alexdobin merged commit 1b56819 into alexdobin:master Feb 4, 2019
@alexdobin
Copy link
Owner

Thanks a lot, Avi!

@k3yavi
Copy link
Contributor Author

k3yavi commented Feb 4, 2019

My pleasure, just one more thing which I was not able to figure out how to fix.
The file which contains the gene names order (as per the matrix) seems to off by a new line or something? If I use the binary in the master branch, it seems to be giving lower-half of the file as blank and the upper half as jumbled up gene names.

@alexdobin
Copy link
Owner

Hi Avi,

there was issue #556 reporting the same probem, and I think I fixed it in the latest patch on master - please try it out. I will make a tagged release tomorrow.

Cheers
Alex

@k3yavi
Copy link
Contributor Author

k3yavi commented Feb 4, 2019

Thanks @alexdobin for the heads up, looking forward to it.

@zhangguy
Copy link

zhangguy commented Feb 6, 2019

Hi @alexdobin
The cellranger matrix.mtx file is space delimited while the STARsolo matrix.mtx is tab delimited. This makes Suerat unable to load. Could you also modify this?
Thanks.

@alexdobin
Copy link
Owner

Hi @zhangguy

I have changed from tabs to spaces, please try the latest patch on Github master.
I will tag 2.7.0c tomorrow.

Cheers
Alex

@zhangguy
Copy link

zhangguy commented Feb 7, 2019

Hi @alexdobin
Thanks for the quick fix for the tab delimit issue. The binary in the main branch is working.

However there is another issue as pointed out by @k3yavi , the first line of genes.tsv is empty. If I read into Seurat using the Read10X function it'll make the first gene name as NA. Do you think the gene names are shifted by one? Thanks.

2019-02-06_20-48-18

[xxxxxx Solo.out]$ more genes.tsv 
	
ENSG00000223972.5	DDX11L1
ENSG00000227232.5	WASH7P
ENSG00000278267.1	MIR6859-1
ENSG00000243485.5	RP11-34P13.3
ENSG00000284332.1	MIR1302-2

@alexdobin
Copy link
Owner

Hi @zhangguy

thanks for reporting this bug, I fixed it please check the GitHub master again.
Hopefully, will tag 2.7.0c tomorrow.

Cheers
Alex

@zhangguy
Copy link

zhangguy commented Feb 8, 2019

Hi @alexdobin
Worked. Lightning fast.
Cheers,
zhangguy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants