Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature type as 3rd column to features.tsv #882

Closed
kehey opened this issue Apr 8, 2020 · 5 comments
Closed

Add feature type as 3rd column to features.tsv #882

kehey opened this issue Apr 8, 2020 · 5 comments

Comments

@kehey
Copy link

kehey commented Apr 8, 2020

Hi @alexdobin,

would you be okay with adding the feature type (like 'Gene Expression') as a third column to the features.tsv output (code)

It would improve the status of CellRanger drop-in replacement as a number of tools (e.g scanpy, dropletUtils) are expecting this column to be filled out for reading using their 10X native reading methods.

It seems that would also make sense to specify since count values could in fact also be e.g. the CRISPR counts. Even if STARSolo does not calculate the others, it seems okay to annotate the Gene Expression ones as being thus.

Or are there reasons to specifically not do this?

@alexdobin
Copy link
Owner

Hi @kehey

good suggestion, I will add it in the next release. The formatting changed in CellRanger v3 compared to v2, which did not have that column.

Cheers
Alex

alexdobin added a commit that referenced this issue May 28, 2020
…xpression' to solo features.tsv file for better compatibility with downstream tools. If solo barcode read length is not checked (--soloBarcodeReadLength 0) and it is shorter than CB+UMI length, the barcode is padded with Ns and not counted.
@alexdobin
Copy link
Owner

Hi @kehey

added the 3rd column "Gene Expression" to match CellRanger output. Please check it out on master, will make an official release shortly.

Cheers
Alex

@kehey
Copy link
Author

kehey commented Jun 2, 2020

Great! I do notice that it is hard coded.

Will this potentially cause issues when people would try to run a CRISPR experiment through STAR? Cfr. https://support.10xgenomics.com/single-cell-gene-expression/software/pipelines/latest/algorithms/crispr

@alexdobin
Copy link
Owner

Hi @kehey,

I am not sure how is the "CRISPR" assay different from the 10X RNA-seq.
I guess I could make this 3rd field optional.

Cheers
Alex

alexdobin added a commit that referenced this issue Jun 16, 2020
…allowing for multiple adapters (e.g. ddSeq). SJ.out.tab is sym-linked as features.tsv for Solo SJ output. Issue #882: 3rd field is now optional in Solo Gene features.tsv with --soloOutFormatFeaturesGeneField3. Issue #936: Throw an error if an empty whitelist is provided to STARsolo.
@alexdobin
Copy link
Owner

Hi @kehey

the 3rd field in the feature.tsv is optional in the 2.7.5a release.

Thanks!
Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants