Skip to content
This repository has been archived by the owner on Jun 8, 2022. It is now read-only.

Try to fix rust-lang/rust#62558 #11

Merged
merged 2 commits into from
Sep 11, 2019
Merged

Try to fix rust-lang/rust#62558 #11

merged 2 commits into from
Sep 11, 2019

Conversation

msizanoen
Copy link
Contributor

This PR will automatically add package=... property into dependency entries without this property and keep the original crate names so that Cargo will automatically pass proper --extern <name>=... flags.
Attempts to fix rust-lang/rust#62558

@alexcrichton
Copy link
Owner

Sure!

@alexcrichton alexcrichton merged commit eeba3a0 into alexcrichton:master Sep 11, 2019
@msizanoen
Copy link
Contributor Author

It was not confirmed that this actually fixes the issue. Please reopen the issue.

@msizanoen
Copy link
Contributor Author

msizanoen commented Sep 11, 2019 •
edited
Loading

If the issue is still not fixed then we will leave out the [lib] name = "..." in the Cargo.toml files to force rename them (to prevent conflict with the proc macros in the sysroot and the rustc build directory) as it will no longer be necessary thanks to this PR.
(It is still a hack though).

@msizanoen msizanoen mentioned this pull request Sep 11, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tools are not available on cross compiled platforms since #61861
2 participants
@msizanoen @alexcrichton