Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not refuse to copy symlinks in build script #236

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Mar 4, 2024

Refusing to copy symlinks
breaks the build under https://github.com/nix-community/naersk.

Fixes #235

@link2xt link2xt mentioned this pull request Mar 4, 2024
@link2xt link2xt marked this pull request as draft March 4, 2024 23:12
@link2xt link2xt marked this pull request as ready for review March 4, 2024 23:43
@link2xt
Copy link
Contributor Author

link2xt commented Mar 4, 2024

Cannot make it to work with git dependency rather than crate at deltachat/deltachat-core-rust#5319, but this is probably another bug: nix-community/naersk#287

This change makes sense in any case and finding ./Configure worked before the change, so will likely work again after merging this and uploading to crates.io.

@alexcrichton alexcrichton merged commit 599f484 into alexcrichton:main Mar 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross-compilation under Nix is broken since #229
2 participants