Support HTTP/2 on static curl-sys on MacOS. #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since rust started using static builds (rust-lang/rust#54919), HTTP/2 hasn't been working on MacOS. The static feature is using the darwinssl backend, which looks like it needs a define to enable some conditional logic to enable ALPN to detect if HTTP/2 is available.
I have no idea if this is safe/wise, but in limited testing on my 10.14 system it seems to work. IIUC, rustc builds on 10.13, so I think these should still apply there. I think
__builtin_availablewas introduced in Xcode 9, but I'm not sure.