Simplify generics #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandermalyga
commented
Jan 14, 2023
| @@ -31,13 +31,13 @@ def unwrap_or(self, default: DefaultT) -> T: | |||
| def unwrap_or(self, default: Any = None) -> Any: | |||
| return self.unwrap() | |||
|
|
|||
| def unwrap_or_else(self, op: Callable[[E], DefaultT]) -> T: | |||
| def unwrap_or_else(self, op: Any) -> T: | |||
There was a problem hiding this comment.
Using Any as the argument's type works, but breaks type inference when using Result.unwrap_or_else() with lambdas. I tried to use NoReturn instead, but MyPy was complaining. So I think this is the best approach for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.