replaced Ok.unwrap_or_else argument type of NoReturn with Any

alexandermalyga · Jan 14, 2023 · 9881bb0 · 9881bb0
1 parent 7dd4b76
commit 9881bb0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 9 deletions.
diff --git a/poltergeist/result.py b/poltergeist/result.py
@@ -31,7 +31,7 @@ def unwrap_or(self, default: DefaultT) -> T:
     def unwrap_or(self, default: Any = None) -> Any:
         return self.unwrap()
 
-    def unwrap_or_else(self, op: NoReturn) -> T:
+    def unwrap_or_else(self, op: Any) -> T:
         return self.unwrap()
 
 

diff --git a/tests/mypy/test_ok.yml b/tests/mypy/test_ok.yml
@@ -27,7 +27,4 @@
   main: |
     from poltergeist import Ok
     instance: Ok[str]
-    reveal_type(instance.unwrap_or_else(lambda e: e))
-  out: |
-    main:3: note: Revealed type is "builtins.str"
-    main:3: error: Argument 1 to "unwrap_or_else" of "Ok" has incompatible type "Callable[[Any], Any]"; expected "NoReturn"  [arg-type]
+    reveal_type(instance.unwrap_or_else(lambda e: e))  # N: Revealed type is "builtins.str"
diff --git a/tests/mypy/test_result.yml b/tests/mypy/test_result.yml
@@ -31,7 +31,4 @@
     instance: Result[str, Exception]
     reveal_type(instance.unwrap_or_else(lambda e: e))  # N: Revealed type is "Union[builtins.str, builtins.Exception]"
     default: str = instance.unwrap_or_else(lambda e: e)  # E: Incompatible types in assignment (expression has type "Union[str, Exception]", variable has type "str")  [assignment]
-    instance.unwrap_or_else(123)
-  out: |
-    main:5: error: Argument 1 to "unwrap_or_else" of "Ok" has incompatible type "int"; expected "NoReturn"  [arg-type]
-    main:5: error: Argument 1 to "unwrap_or_else" of "Err" has incompatible type "int"; expected "Callable[[Exception], <nothing>]"  [arg-type]
+    instance.unwrap_or_else(123)  # E: Argument 1 to "unwrap_or_else" of "Err" has incompatible type "int"; expected "Callable[[Exception], <nothing>]"  [arg-type]