Changed the ytview file corresponding to change on youtube html sourc… #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e code
Pull Request Label:
Pull Request Checklist:
bats tests?I ran the tests locally, but the issues weren't related to my changes.
The Problem with ytview was that youtube had changed its HTML structure, but ytview was still expecting the old HTML structure. I tweaked the file ytview to make it work. Now, anyone can search for a topic and watch the video. Though, the channel part still needs to be re-implemented.
Previous Issue and Output:
Output after the change:
Also, initially, the command "search=$(printf '%s ' "$@")" would result in -s being added along with the string to be searched to the search variable, but now only the string to be searched is added. The only compromise is that the user has to enter the string in double or single quotes. And for that, I have changed the help menu.