Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest private vars and add :deprecated key #98

Closed
wants to merge 2 commits into from

Conversation

eval
Copy link
Contributor

@eval eval commented Jun 30, 2023

This PR adds two things:

  • the earlier discussed suggestion of private vars when using #'some-ns/,,,
  • adding a :deprecated key to suggested vars and functions

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (ba4f21b) 93.10% compared to head (b2d7a7e) 93.13%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   93.10%   93.13%   +0.02%     
==========================================
  Files          11       11              
  Lines         740      743       +3     
  Branches       28       28              
==========================================
+ Hits          689      692       +3     
  Misses         23       23              
  Partials       28       28              
Impacted Files Coverage Δ
src/compliment/sources/ns_mappings.clj 89.65% <100.00%> (+0.36%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eval eval force-pushed the suggest-private-vars branch from b2d7a7e to b906dd7 Compare June 30, 2023 10:50
@eval eval marked this pull request as ready for review June 30, 2023 10:51
@eval eval closed this Jun 30, 2023
@eval
Copy link
Contributor Author

eval commented Jun 30, 2023

Closing as GH keeps telling about merge-conflicts which were solved...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants