fix: not using the mode from the config file #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krystianotto Thanks, it will be merged after testing without problems. |
|
@alex8088 Do you have a date for the upcoming release in which this fix will be included? Thanks! |
mamboer
pushed a commit
to mamboer/electron-vite
that referenced
this pull request
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in #531 electron-vite does not take into account the mode entered from the configuration file. This PR fixes this issue.
Additional context
Following the documentation, the mode is taken first from
--modeand then from the configuration, and the default is determined by the command.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).