Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix update issuse by adding current ref #93

Merged

Conversation

DVGY
Copy link
Contributor

@DVGY DVGY commented Feb 15, 2021

#90
I found few bugs my above branch.

I fixed update logic, which was not executing properly.
I added layer.addTo(map) so that map works properly.

I found this bug while working on my personal project and the problem I faced is mentioned here
found bug in my code

Note this bug was visible in CRA bootstrapped app, but in custom webpack config I was not able to detect this bug

@srghma @agusterodin Please review

@DVGY DVGY mentioned this pull request Feb 15, 2021
@srghma
Copy link
Collaborator

srghma commented Mar 29, 2021

so, the createDrawElement was outside of useEffect.

I don't really understand what the layer.addTo(map) does or why it was omitted before, but the changes seem fine for me

@sinnrrr what do you think?

@sinnrrr
Copy link

sinnrrr commented Mar 29, 2021

@srghma looks good

@srghma srghma merged commit 24351fa into alex3165:master Mar 29, 2021
@srghma
Copy link
Collaborator

srghma commented Mar 29, 2021

published at 0.19.7

@srghma
Copy link
Collaborator

srghma commented Mar 29, 2021

@DVGY I wish I could add you to this repo as maintainer, but I dont see the "settings" page

@sinnrrr can you?

@sinnrrr
Copy link

sinnrrr commented Mar 29, 2021

@srghma no, I don't have them too

I believe you should have this page on top panel of the repo page because you have the "Collaborator" badge

@srghma
Copy link
Collaborator

srghma commented Mar 29, 2021

i'm contributor, not collaborator

this is what I see

screencapture-github-alex3165-react-leaflet-draw-2021-03-29-21_11_49

@sinnrrr
Copy link

sinnrrr commented Mar 29, 2021

@srghma
image

it shows here, that you were invited as a collaborator, you should probably check your email then

@srghma
Copy link
Collaborator

srghma commented Mar 29, 2021

no, I dont have any email)

@DVGY
Copy link
Contributor Author

DVGY commented Apr 2, 2021

no, I dont have any email)

@srghma Sorry for the late reply. For some odd reasons I was not getting notified. You can add me as a repo maintainer. Thanks happy to contribute.

@srghma
Copy link
Collaborator

srghma commented Apr 2, 2021

@DVGY I cannot, as I said I wish I could, but neither @sinnrrr nor I have rights

actually, maybe I have, but I dont see where (image above)

@alex3165 , could you give @DVGY access to this repo OR could you make either of us 3 an admin for this repo?

@DVGY
Copy link
Contributor Author

DVGY commented Apr 3, 2021

@DVGY I cannot, as I said I wish I could, but neither @sinnrrr nor I have rights

actually, maybe I have, but I dont see where (image above)

@alex3165 , could you give @DVGY access to this repo OR could you make either of us 3 an admin for this repo?

Not a big issue I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants