Fix server side rendering with (not only) Nuxt #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without testUrl "SecurityError: localStorage is not available for opaque origins" errors happens with latest jsdom. Refer jsdom/jsdom#2304 to more detail information. Also shallow deprecation has been resolved.
Fixes nuxt/nuxt#995 Browser File API is not available when server side rendering is used in Nuxt universal app. This error can't be easilly solved outside vue-picture-input. Although Nuxt provides variable to distinguish client/server rendering this bug occurs just by importing PictureInput. Because conditional input is not easilly possible with ES6 only workaround is direct patch of PictureInput. Sadly I don't find easy way how to write test. @vue/test-utils mocks File object despite vue-server-renderer is used. But in a real Nuxt app File is undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes nuxt/nuxt#995
Browser File API is not available when server side rendering
is used in Nuxt universal app.
This error can't be easilly solved outside vue-picture-input.
Although Nuxt provides variable to distinguish client/server
rendering this bug occurs just by importing PictureInput. Because
conditional input is not easilly possible with ES6 only workaround
is direct patch of PictureInput.
Sadly I don't find easy way how to write test. @vue/test-utils mocks
File object despite vue-server-renderer is used. But in a real Nuxt
app File is undefined.