The edit/remove buttons should not be submittable #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, When the user has picked an image, the buttons to modify or remove this image appear. If, further down in the form, the user presses "Enter" to submit the form, the event is picked by the first submit button which is the vue-picture-input "modify image" button. This PR fixes this behaviour by setting these buttons on the type "button" instead of the default "submit". Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
When the user has picked an image, the buttons to modify or remove this image appear. If, further down in the form, the user presses "Enter" to submit the form, the event is picked by the first submit button which is the vue-picture-input "modify image" button, and not our form submit button. So it triggers the file select window instead of submitting the form.
This PR fixes this behaviour by setting these buttons on the type "button" instead of the default "submit".
Thanks!