Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement server-side pagination and filtering #568

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

krzysdabro
Copy link
Contributor

@krzysdabro krzysdabro commented May 22, 2023

Description
UI incorrectly shows only 50 total blackouts/users/keys/... even though API can list much more. This PR adds server-side pagination and filtering to fix the problem.

Depends on alerta/alerta#1864
Fixes #528, alerta/alerta#1550

Changes
Fixes pagination and filtering on pages with lists

Screenshots
If it's a UI change add screenshots to demonstrate changes.

Checklist

  • Pull request is limited to a single purpose
  • Code style/formatting is consistent
  • All existing tests are passing
  • Added new tests related to change
  • No unnecessary whitespace changes

Collaboration
When a user creates a pull request from a fork that they own, the user
generally has the authority to decide if other users can commit to the
pull request's compare branch. If the pull request author wants greater
collaboration, they can grant maintainers of the upstream repository
(that is, anyone with push access to the upstream repository) permission
to commit to the pull request's compare branch

See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@netlify
Copy link

netlify bot commented May 22, 2023

Deploy Preview for peaceful-beignet-dcf974 ready!

Name Link
🔨 Latest commit d547788
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-beignet-dcf974/deploys/64a16195dfc4e100082b39bb
😎 Deploy Preview https://deploy-preview-568--peaceful-beignet-dcf974.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@satterly satterly merged commit d9b1155 into alerta:master Dec 21, 2023
@satterly
Copy link
Member

Thanks 👍

@satterly satterly added the enhancement New feature or request label Dec 21, 2023
satterly added a commit that referenced this pull request Apr 10, 2024
satterly added a commit that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: why Alerta gui shows only 50 users ?
2 participants