Push Docker images for tags only #3008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stchris
approved these changes
Apr 25, 2023
stchris
requested changes
Apr 25, 2023
|
Ha, thanks for catching this! I opened the PR with too much confidence and then didn't bother to check the CI status 😄 |
|
I agree with Chris. We don't need to publish absolutely everything. Better only to publish the things we tag. |
We have implemented a process that uses release candidates for pre-release testing and deployments, so there’s no need anymore to push Docker images for every commit. This is wasteful in terms of bandwidth and storage resources and clutters the image repository.
tillprochaska
force-pushed
the
push-images-for-tags-only
branch
from
87b7dc0 to
063b1b9
Compare
stchris
approved these changes
Apr 25, 2023
|
Alright, thanks again for catching my mistakes. I’ve fixed the workflow and tested it to make sure it will publish images for tagged commits successfully ;) https://github.com/alephdata/aleph/pkgs/container/aleph/88237955?tag=test-updated-workflows |
Rosencrantz
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have implemented a process that uses release candidates for pre-release testing and deployments, so there’s no need anymore to push Docker images for every commit. This is wasteful in terms of bandwidth and storage resources and clutters the image repository.
@catileptic @Rosencrantz @stchris This is something we have discussed a few times before, tbh I’m not sure anymore what exactly our conclusion was. Let me know if you have concerns or in case we do actually still depend on images built from commits that are not tagged.