Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling #550

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Improve error handling #550

merged 2 commits into from
Feb 12, 2024

Conversation

hoh
Copy link
Member

@hoh hoh commented Jan 31, 2024

Two small improvements in error handling and reporting

  • Fix: Sentry AsyncioIntegration was missing
  • Fix: Response was processed even in case of error status code

@hoh hoh requested a review from nesitor February 2, 2024 10:08
hoh added 2 commits February 12, 2024 16:38
This integration helps with reporting errors from asyncio tasks.
Solution: Call `raise_for_status` before parsing and returning the response data.
@hoh hoh force-pushed the hoh-error-handling branch from c6cc74f to 799d6ff Compare February 12, 2024 15:38
@hoh hoh merged commit 7b70409 into main Feb 12, 2024
2 checks passed
@hoh hoh deleted the hoh-error-handling branch February 12, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants